-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tools kubectl
, tools wait-for
& Wait Action.
#1373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-mccoy
requested review from
YrrepNoj,
Racer159,
Madeline-UX,
JasonvanBrackel and
RothAndrew
as code owners
February 19, 2023 10:17
✅ Deploy Preview for zarf-docs canceled.
|
This change will remove the dependency of the |
Switched back to draft until I can push up the action changes. |
jeff-mccoy
requested review from
mike-winberry,
Noxsios and
a team
as code owners
February 21, 2023 14:49
Racer159
requested changes
Feb 21, 2023
Racer159
requested changes
Feb 21, 2023
Co-authored-by: Wayne Starr <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Racer159
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jeff-mccoy
changed the title
Add
Add Feb 21, 2023
tools kubectl
and tools wait-for
commandstools kubectl
, tools wait-for
& Wait Action.
Noxsios
pushed a commit
that referenced
this pull request
Mar 8, 2023
Vendors in kubectl and adds a new `zarf tools wait-for` command that is wrapper around `kubectl get` + `kubectl wait`. Also adds a new concept of a `wait action`. Features: - Wait for k8s resources to exist - Wait for k8s resources to exist & have a specified status - Use name or label selectors for k8s resources - Wait for http(s) endpoints to have a specific response code - Wait for generic network endpoints to appear to be up - Specify a custom timeout window ![Screenshot 2023-02-20 at 10 24 17 AM](https://user-images.githubusercontent.com/882485/220378021-0a921e90-ccba-4fc7-a3ce-d4a55f3d993a.png) ## Related Issue ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors in kubectl and adds a new
zarf tools wait-for
command that is wrapper aroundkubectl get
+kubectl wait
. Also adds a new concept of await action
.Features:
Related Issue
Type of change
Checklist before merging