Deploying nonexistent components #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YrrepNoj
commented
Oct 14, 2021
YrrepNoj
changed the title
YrrepNoj
force-pushed
the
feature/handle-nonexistent-components
branch
from
a0a24e6 to
4215c87
Compare
YrrepNoj
changed the title
RothAndrew
reviewed
Oct 15, 2021
YrrepNoj
force-pushed
the
feature/handle-nonexistent-components
branch
from
4215c87 to
aa7b782
Compare
|
/test all |
|
/test all |
YrrepNoj
force-pushed
the
feature/handle-nonexistent-components
branch
from
aa7b782 to
f8368d5
Compare
|
/test all |
|
@YrrepNoj let's add an E2E to cover the failing case, i.e. insert bad component name, the deploy step should abort. |
YrrepNoj
force-pushed
the
feature/handle-nonexistent-components
branch
from
f8368d5 to
d8a3839
Compare
|
/test all |
jeff-mccoy
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to make sure that all components passed in with the
--componentsflag during a./zarf initor ./zarf package deploy` command exist. Errors out if unable to match a provided component to the components listed in the yaml.