Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Big Bang example NetworkPolicy CIDRs #104

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

RothAndrew
Copy link
Contributor

What/Why

  • Change the NetworkPolicy CIDRs back to 0.0.0.0/0 so that the example can work on different Linux distros and other user environments.

@RothAndrew RothAndrew requested a review from jeff-mccoy October 11, 2021 17:59
@RothAndrew RothAndrew self-assigned this Oct 11, 2021
@RothAndrew
Copy link
Contributor Author

/test all

@jeff-mccoy
Copy link
Contributor

I guess we don’t block without tests yet?

@RothAndrew
Copy link
Contributor Author

I guess we don’t block without tests yet?

Not yet. I think it's ready to turn on though. All it does right now is zarf --help and zarf init and asserting that the exit codes are zero, but it's enough of a start as we build it out more.

@RothAndrew RothAndrew merged commit cb70168 into master Oct 11, 2021
@RothAndrew RothAndrew deleted the feature/fix-big-bang-example-cidrs branch October 11, 2021 18:08
jeff-mccoy pushed a commit that referenced this pull request Feb 8, 2022
Noxsios pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants