Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fix space/padding around Package Deployment Stepper #799

Closed
Madeline-UX opened this issue Sep 27, 2022 · 0 comments · Fixed by #826
Closed

Fix fix space/padding around Package Deployment Stepper #799

Madeline-UX opened this issue Sep 27, 2022 · 0 comments · Fixed by #826
Assignees
@mike-winberry
Milestone
v0.26.1 (Zarf UI)

Comments

@Madeline-UX
Copy link
Contributor

Fix flex spacing and padding between objects.

Design File
https://www.figma.com/file/MUItIzpzLBLuIyt225Bwgl/Zarf-UI?node-id=36%3A45144

Screen Shot 2022-09-27 at 1 45 01 PM
@Madeline-UX Madeline-UX added the UI label Sep 27, 2022
@Madeline-UX Madeline-UX added this to the Zarf UI - MVP milestone Sep 27, 2022
@Madeline-UX Madeline-UX moved this to New Requests in Zarf Project Board Sep 27, 2022
@Madeline-UX Madeline-UX moved this from New Requests to Backlog in Zarf Project Board Sep 27, 2022
@mike-winberry mike-winberry moved this from Backlog to Doing Now in Zarf Project Board Oct 2, 2022
@mike-winberry mike-winberry linked a pull request Oct 2, 2022 that will close this issue
UI Typography/Layout Fixes. #826
Merged
17 tasks
@mike-winberry mike-winberry mentioned this issue Oct 2, 2022
Merged
17 tasks
mike-winberry added a commit that referenced this issue Oct 8, 2022
@mike-winberry @jeff-mccoy @Racer159
UI Typography/Layout Fixes. (#826)
e6ca655 
## Description
- [x] Fix Typography and Layout across application to match design and
use new Unicorn-UI typography component.
  - [x] home
  - [x] initialize
    - [x] configure
    - [x] review
    - [x] deploy
    - [x] finished
- [x] Fix pre-tag first line indentation in package-component.
- [x] Create Accordion Group Component that follows the design.
- [x] add caption to Package Component Section of init/config page.
- [x] globally style caption color.
- [x] Sanitize block margin, margin and padding in app.css. 
- [x] Add api call for currently deploying components that can access
private variable stored in config.go that gets populated and cleared
during deploy method.
- [x] Update deploy page to fill the stepper as components are
"deployed" and navigate away from page after pop up with successful
deployment shows.
- [x] Update tests. 
## Related Issue
- #799  
- #798 
- #797  
- #802 

## Type of change
- UI: Frontend styling/theme

## Check list before merging
- [x]  Changes have been linted locally
- [x] Tests passing

Co-authored-by: Megamind <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Repository owner moved this from Doing Now to Done in Zarf Project Board Oct 8, 2022
Noxsios pushed a commit that referenced this issue Mar 8, 2023
@mike-winberry @jeff-mccoy @Racer159
UI Typography/Layout Fixes. (#826)
ae25283 
## Description
- [x] Fix Typography and Layout across application to match design and
use new Unicorn-UI typography component.
  - [x] home
  - [x] initialize
    - [x] configure
    - [x] review
    - [x] deploy
    - [x] finished
- [x] Fix pre-tag first line indentation in package-component.
- [x] Create Accordion Group Component that follows the design.
- [x] add caption to Package Component Section of init/config page.
- [x] globally style caption color.
- [x] Sanitize block margin, margin and padding in app.css. 
- [x] Add api call for currently deploying components that can access
private variable stored in config.go that gets populated and cleared
during deploy method.
- [x] Update deploy page to fill the stepper as components are
"deployed" and navigate away from page after pop up with successful
deployment shows.
- [x] Update tests. 
## Related Issue
- #799  
- #798 
- #797  
- #802 

## Type of change
- UI: Frontend styling/theme

## Check list before merging
- [x]  Changes have been linted locally
- [x] Tests passing

Co-authored-by: Megamind <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mike-winberry mike-winberry

Labels
None yet
Projects
None yet
Milestone
v0.26.1 (Zarf UI)
Development

Successfully merging a pull request may close this issue.

UI Typography/Layout Fixes. zarf-dev/zarf
2 participants
@mike-winberry @Madeline-UX