Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart --insecure #2860

Closed
Noxsios opened this issue Aug 8, 2024 · 1 comment · Fixed by #2936
Closed

Break apart --insecure #2860

Noxsios opened this issue Aug 8, 2024 · 1 comment · Fixed by #2936
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers

Comments

@Noxsios
Copy link
Contributor

Noxsios commented Aug 8, 2024

Is your feature request related to a problem? Please describe.

Currently the --insecure flag is overloaded to be both --http-only and --tls-skip-verify. This means that if you have a resource w/ a self-signed cert (like a OCI/Docker registry) Zarf will be unable to access that resource because it only requests over HTTP.

For 1.0 it would be beneficial if these flags were separated similar to other tools helm, oras.

Not sure if you want Helm's full blown CA support though:

      --ca-file string             verify certificates of HTTPS-enabled servers using this CA bundle
      --cert-file string           identify HTTPS client using this SSL certificate file
      --insecure-skip-tls-verify   skip tls certificate checks for the repository
      --key-file string            identify HTTPS client using this SSL key file
@Noxsios Noxsios added the enhancement ✨ New feature or request label Aug 8, 2024
@AustinAbro321 AustinAbro321 added the good first issue 🥇 Good for newcomers label Aug 15, 2024
@AustinAbro321
Copy link
Contributor

AustinAbro321 commented Aug 15, 2024

Agree with this and added a good first issue label. We can deprecate and hide the --insecure flag and have it set --http-only to true and --insecure-tls-skip-verify to true for any legacy users of --insecure.

joonas added a commit to joonas/zarf that referenced this issue Aug 28, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 1, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 1, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 5, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 5, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 7, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 7, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 7, 2024
joonas added a commit to joonas/zarf that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue 🥇 Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants