Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCI source autocompletion #2154

Open
Racer159 opened this issue Nov 17, 2023 · 0 comments
Open

OCI source autocompletion #2154

Racer159 opened this issue Nov 17, 2023 · 0 comments
Labels
enhancement ✨ New feature or request

Comments

@Racer159
Copy link
Contributor

Racer159 commented Nov 17, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

For removing or inspecting packages the cluster source will autocomplete using Cobra shell completions. It would be nice to expand the functionality to work for OCI sources once someone enters oci://domain/ to effectively catalog it - we could also do a tag list once the : was typed.

Describe the solution you'd like

  • Given I have shell completions installed
  • And I have Zarf packages in an OCI registry
  • When I type zarf package deploy|remove|inspect|pull oci://domain/
  • And press <TAB>
  • Then a list of available packages is shown
  • And When I select a package and type :
  • And press <TAB>
  • Then a list of available package tags is shown

Additional context

This was initially brought up for remove / inspect here: #2151 - but it may be good to centralize some of this in the sources package long term so that the functionality can be consistent.
@Racer159 Racer159 added the enhancement ✨ New feature or request label Nov 17, 2023
@Racer159 Racer159 added this to the The Bucket milestone Nov 17, 2023
@Racer159 Racer159 mentioned this issue Nov 17, 2023
Merged
5 tasks
Racer159 added a commit that referenced this issue Nov 28, 2023
@WeaponX314 @Racer159
feat: add zarf package remove/inspect completion for cluster sources (
fb9872c 
#2151)

## Description

- Added `zarf package remove` shell completion ability
- Added `zarf package inspect` shell completion ability
- Added `zarf package list` alias "ls" (since ls is so commonly used)
- Added `zarf package remove` alias "rm" (since rm is so commonly used)

## Related Issue

Fixes #2150 
Partial: #2154 (inspect only)

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [X] Test, docs, adr added or updated as needed
- [X] [Contributor Guide
Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow)
followed

---------

Co-authored-by: Wayne Starr <[email protected]>
@Racer159 Racer159 changed the title Cluster and OCI source autocompletion OCI source autocompletion Dec 1, 2023
@Noxsios Noxsios moved this to Backlog in Zarf (old) Mar 7, 2024
@salaxander salaxander removed this from the The Bucket milestone Jul 3, 2024
@salaxander salaxander added this to Zarf Jul 22, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zarf Jul 22, 2024
@salaxander salaxander removed the status in Zarf Jul 22, 2024
@salaxander salaxander moved this to Triage in Zarf Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
Zarf
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@salaxander @Racer159