Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect expected size for progress bar on image downloads #1488

Closed
YrrepNoj opened this issue Mar 27, 2023 · 0 comments · Fixed by #1489
Closed

Incorrect expected size for progress bar on image downloads #1488

YrrepNoj opened this issue Mar 27, 2023 · 0 comments · Fixed by #1489
Labels
possible-bug 🐛

Comments

@YrrepNoj
Copy link
Contributor

When Zarf is pulling images to create a package it generates a progress bar to indicate.. well progress.

Right now the progress bar is displaying an incorrect value for the total bytes that are going to be downloaded because it is not accounting for the fact that some images may share layers.

When creating the progress bar, we should take into account duplicate layers so that we can provide a more accurate representation of the progress of the image pulls.
@github-project-automation github-project-automation bot moved this to New Requests in Zarf Project Board Mar 27, 2023
@YrrepNoj YrrepNoj mentioned this issue Mar 27, 2023
Merged
@Racer159 Racer159 mentioned this issue Mar 27, 2023
Closed
Racer159 added a commit that referenced this issue Mar 27, 2023
@YrrepNoj @Racer159
update calculation for the expected bytes during image layer pulls (#…
d9d0dc6 
…1489)

## Description

The progress bar 'expected bytes' now takes duplicate layers into
account

Fixes #1488

Signed-off-by: Jon Perry <[email protected]>
Co-authored-by: Wayne Starr <[email protected]>
@github-project-automation github-project-automation bot moved this from New Requests to Done in Zarf Project Board Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
possible-bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update calculation for the expected bytes during image layer pulls zarf-dev/zarf
1 participant
@YrrepNoj