Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup master branch references in docs #1057

Closed
Noxsios opened this issue Nov 29, 2022 · 1 comment · Fixed by #1169
Closed

Cleanup master branch references in docs #1057

Noxsios opened this issue Nov 29, 2022 · 1 comment · Fixed by #1169
Assignees
@gscallon
Labels
documentation 📘 Improvements or additions to documentation good first issue 🥇 Good for newcomers possible-bug 🐛

Comments

@Noxsios
Copy link
Contributor

Noxsios commented Nov 29, 2022

Fix refs to master in https://github.com/defenseunicorns/zarf/blob/main/.hooks/zarf-jsfh-template/base.md . Github does redirect, but all files should reflect new main branch naming.
@RothAndrew RothAndrew moved this to New Requests in Zarf Project Board Nov 29, 2022
@Noxsios Noxsios added documentation 📘 Improvements or additions to documentation good first issue 🥇 Good for newcomers labels Nov 29, 2022
@gscallon gscallon mentioned this issue Jan 7, 2023
Merged
@gscallon gscallon self-assigned this Jan 7, 2023
@gscallon
Copy link
Contributor

gscallon commented Jan 7, 2023

I created the following PR which addresses this issue: #1169

jeff-mccoy pushed a commit that referenced this issue Jan 7, 2023
@gscallon
1057 cleanup master branch refs -> update to use "main" in docs (#1169)
a59e729 
## Description

A while back, there was a switch from "master" to "main" branch. There
were links that referenced master and have now been replaced with main.
This avoids GitHub having to redirect to the new URL each time the old
branch name is used in the link.

## Related Issue

Fixes #1057 

## Type of change

- [ x ] Bug fix (non-breaking change which fixes an issue)

## Checklist before merging

N/A - docs update
@github-project-automation github-project-automation bot moved this from New Requests to Done in Zarf Project Board Jan 7, 2023
Noxsios pushed a commit that referenced this issue Mar 8, 2023
@gscallon
1057 cleanup master branch refs -> update to use "main" in docs (#1169)
9b3bcae 
## Description

A while back, there was a switch from "master" to "main" branch. There
were links that referenced master and have now been replaced with main.
This avoids GitHub having to redirect to the new URL each time the old
branch name is used in the link.

## Related Issue

Fixes #1057 

## Type of change

- [ x ] Bug fix (non-breaking change which fixes an issue)

## Checklist before merging

N/A - docs update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gscallon gscallon

Labels
documentation 📘 Improvements or additions to documentation good first issue 🥇 Good for newcomers possible-bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1057 cleanup master branch refs -> update to use "main" in docs zarf-dev/zarf
2 participants
@gscallon @Noxsios