de-giteaify condition

Signed-off-by: Austin Abro <[email protected]>

src/test/external/common.go

@@ -32,15 +32,15 @@ func createPodInfoPackageWithInsecureSources(t *testing.T, temp string) {
 	exec.CmdWithPrint(zarfBinPath, "package", "create", temp, "--confirm", "--output", temp)
 }
 
-func verifyWaitSuccess(t *testing.T, timeoutMinutes time.Duration, cmd string, args []string, condition string) error {
+func waitForCondition(t *testing.T, timeoutMinutes time.Duration, cmd string, args []string, condition string) error {
 	timeout := time.After(timeoutMinutes * time.Minute)
 	for {
 		// delay check 3 seconds
 		time.Sleep(3 * time.Second)
 		select {
 		// on timeout abort
 		case <-timeout:
-			return errors.New("unable to verify the gitea container installed successfully")
+			return errors.New("timed out waiting for condition")
 
 			// after delay, try running
 		default:

src/test/external/ext_out_cluster_test.go

@@ -82,7 +82,7 @@ func (suite *ExtOutClusterTestSuite) SetupSuite() {
 
 	// Wait for gitea to deploy properly
 	giteaArgs := []string{"inspect", "-f", "{{.State.Health.Status}}", "gitea.localhost"}
-	err = verifyWaitSuccess(suite.T(), 2, "docker", giteaArgs, "healthy")
+	err = waitForCondition(suite.T(), 2, "docker", giteaArgs, "healthy")
 	suite.NoError(err)
 
 	// Connect gitea to the k3d network