Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/tree): CdkTreeNodeToggle focuses node when toggling it #1

Closed
wants to merge 1 commit into from
Closed

fix(cdk/tree): CdkTreeNodeToggle focuses node when toggling it #1

wants to merge 1 commit into from

Commits on Aug 10, 2023

  1. fix(cdk/tree): CdkTreeNodeToggle focuses node when toggling it 

    Fix focus behavior of CdkTreeNodeToggle. When toggling the expanded or
collapsed state of a node, focus that node. Fix issue where end user
cannot tab into tree component when collaping the parent of the active
node.

Before this commit is applied, there is a bug where end user cannot tab
into the tree.

Reproduction steps
1. Active a tree node
2. (focus state renders)
3. Using mouse, collapse parent of node from step 1.
4. (tree node collapses)
5. Press Tab, then shift + tab
6. (item before tree is focused. Can tab into the tree)

With this commit applied, above issue is no longer expected to
reproduce.

This commit message is only for reviewers of this PR and can be deleted
when landing this change in main.
    @zarend
    zarend committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    c80f400 View commit details
    Browse the repository at this point in the history