Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the bottom drawer #565

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

psiinon
Copy link
Member

@psiinon psiinon commented Jul 25, 2019

Fixes #552

Signed-off-by: Simon Bennetts [email protected]

@psiinon psiinon requested review from thc202 and dscrobonia July 25, 2019 16:05
@psiinon
Copy link
Member Author

psiinon commented Jul 26, 2019

Ah, looks like the unit tests are failing. I'll fix them and also add some more to check this new functionality :)

@psiinon psiinon force-pushed the feature/hidedrawer branch from e72ab2d to 6f4b74d Compare July 26, 2019 14:33
@psiinon
Copy link
Member Author

psiinon commented Jul 26, 2019

Fixed the failing test and added new ones to cover the new functionality :)
Ready for review now.

Signed-off-by: Simon Bennetts <[email protected]>
@psiinon psiinon force-pushed the feature/hidedrawer branch from 6f4b74d to 1e24286 Compare July 29, 2019 12:12
Copy link
Contributor

@dscrobonia dscrobonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@psiinon psiinon merged commit 877eda0 into zaproxy:develop Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

the HUD is blocking view of lower tabs
3 participants