Add API endpoints for getting and setting UI options #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
feature/api-ui-options
branch
from
b1ae3e8 to
610556f
Compare
psiinon
force-pushed
the
feature/api-ui-options
branch
2 times, most recently
from
f0a5dde to
a6a3230
Compare
thc202
approved these changes
Jan 2, 2019
feature/api-ui-options
psiinon
force-pushed
the
feature/api-ui-options
branch
from
a6a3230 to
eb3ffe1
Compare
thc202
approved these changes
Jan 2, 2019
dscrobonia
approved these changes
Jan 3, 2019
|
@dscrobonia can always change things once you have had a chance to use them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
@dscrobonia are these endpoints suitable for getting and setting the UI options?
The values are just strings, but they could be parsed as json / whatever if thats useful.
Theres no upper limit to the size of the values that can be set, but I'd suggest keeping them relatively small if possible.