You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, I've started adding the beforeDestroy hooks per #468 , but have noticed that you aren't using any enforced linting or canonical JS style. This means that there are a mixture of tabs and five spaces etc. It's hard for me to know what is canonical.
And after seeing the really awesome PR I had to #459 (review) it. And in that context I think its probably better for me NOT to work on the code at the moment and to wait for that PR to be polished and land.
The text was updated successfully, but these errors were encountered:
So, I've started adding the beforeDestroy hooks per #468 , but have noticed that you aren't using any enforced linting or canonical JS style. This means that there are a mixture of tabs and five spaces etc. It's hard for me to know what is canonical.
And after seeing the really awesome PR I had to #459 (review) it. And in that context I think its probably better for me NOT to work on the code at the moment and to wait for that PR to be polished and land.
The text was updated successfully, but these errors were encountered: