-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't forget to turn off Vue eventBus listeners. #468
Comments
@nothingismagick thanks for letting us know! Most of us working on the HUD are pretty new to modern JS UI's so all feedback is much appreciated. So are PRs - so if you fancy showing how it should be done then please go ahead :D |
I absolutely love the HUD and am happy to contribute. Will make a PR las soon as I clean my plate - and plan on integrating this into the Quasar Framework's app extension family within our testing harnesses. |
Great! FYI we have a Google Group for the HUD here: https://groups.google.com/group/zaproxy-hud and a weekly Google Hangout - just let us know if you might like to join that and we'll send you an invite :) |
Closing this because of this issue I just linked and this #459 (review) I just did. |
Reopening as its currently an issue and we dont know when #459 will be merged... |
You are making awesome use of the event listeners (e.g. here: https://github.com/zaproxy/zap-hud/blob/develop/src/main/zapHomeFiles/hud/display.js ), but best practice would suggest cleaning up your eventBus listeners with the beforeDestroy hook and calling
eventBus.$off
.For your reference: https://vuejs.org/v2/api/#Instance-Methods-Events
The text was updated successfully, but these errors were encountered: