Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forget to turn off Vue eventBus listeners. #468

Closed
nothingismagick opened this issue Apr 22, 2019 · 5 comments
Closed

Don't forget to turn off Vue eventBus listeners. #468

nothingismagick opened this issue Apr 22, 2019 · 5 comments
Labels
Milestone

Comments

@nothingismagick
Copy link
Contributor

You are making awesome use of the event listeners (e.g. here: https://github.com/zaproxy/zap-hud/blob/develop/src/main/zapHomeFiles/hud/display.js ), but best practice would suggest cleaning up your eventBus listeners with the beforeDestroy hook and calling eventBus.$off.

For your reference: https://vuejs.org/v2/api/#Instance-Methods-Events

@psiinon
Copy link
Member

psiinon commented Apr 23, 2019

@nothingismagick thanks for letting us know! Most of us working on the HUD are pretty new to modern JS UI's so all feedback is much appreciated. So are PRs - so if you fancy showing how it should be done then please go ahead :D

@nothingismagick
Copy link
Contributor Author

I absolutely love the HUD and am happy to contribute. Will make a PR las soon as I clean my plate - and plan on integrating this into the Quasar Framework's app extension family within our testing harnesses.

@psiinon
Copy link
Member

psiinon commented Apr 23, 2019

Great! FYI we have a Google Group for the HUD here: https://groups.google.com/group/zaproxy-hud and a weekly Google Hangout - just let us know if you might like to join that and we'll send you an invite :)

@nothingismagick
Copy link
Contributor Author

Closing this because of this issue I just linked and this #459 (review) I just did.

@psiinon
Copy link
Member

psiinon commented Apr 29, 2019

Reopening as its currently an issue and we dont know when #459 will be merged...

@psiinon psiinon reopened this Apr 29, 2019
@psiinon psiinon closed this as completed in 74f8da7 May 9, 2019
@thc202 thc202 added this to the 0.4.0 milestone May 9, 2019
@thc202 thc202 added the bug label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants