openapi: add Application/XML support for request bodies #5751
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
This comment has been minimized.
This comment has been minimized.
| generateXmlElements(property.getValue(), xml); | ||
| } else { | ||
| String value = dataGenerator.generateValue(elementName, property.getValue(), false); | ||
| if ("string".equals(property.getValue().getType()) |
There was a problem hiding this comment.
Yes, this function can handle nested objects because the generateXmlElements function utilizes recursion to create correct XML tags. Also, maybe it's better to use equalsIgnoreCase in this case. I didn't think of that before. Would you like to fix it, or should I make the changes with a new commit?
There was a problem hiding this comment.
The could do an amending commit and force push
There was a problem hiding this comment.
thank you for the advice and now you can review it again :)
This commit adds support for handling Application/XML content types in request bodies.This enhancement resolves Issue #6767 Signed-off-by:Tryfon Iason Papatriantafyllou <[email protected]>
trypa11
force-pushed
the
origin/openapiAppXml
branch
from
c8d1a8c
to
6d7c217
Compare
|
Was this tested with an actual application? Because I would have expected a root element to be present (even a dummy one), if we end up merging this we should be very clear that we are producing malformed XML document or that we produce only XML fragments. |
|
In the long run it may be better to use an actual XML Writer of some sort instead of 'manually' building the XML. |
|
Even in that case we will not be able to generate the correct payload as the OpenAPI spec does not always have all the info necessary to generate it. |
This commit adds support for handling Application/XML content types in request bodies for OpenAPI files
Overview
I added a new functionality that creates the XML body for the application/XML from OpenAPI files. Below is the output I received from ZAP after implementing the code.In this example, I modified the application/json schemas of the Crapi OpenAPI file to application/XML and achieved this outcome.
If you have any concerns or observations, please let me know.
Related Issues
zaproxy/zaproxy#6767
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.