Upgrade to TypeSpec 0.58 (Azure#29863)

package.json

@@ -2,20 +2,20 @@
   "name": "azure-rest-api-specs",
   "devDependencies": {
     "@azure-tools/typespec-apiview": "0.4.9",
-    "@azure-tools/typespec-autorest": "0.43.0",
-    "@azure-tools/typespec-azure-core": "0.43.0",
-    "@azure-tools/typespec-azure-portal-core": "0.43.0",
-    "@azure-tools/typespec-azure-resource-manager": "0.43.0",
-    "@azure-tools/typespec-azure-rulesets": "0.43.0",
+    "@azure-tools/typespec-autorest": "0.44.0",
+    "@azure-tools/typespec-azure-core": "0.44.0",
+    "@azure-tools/typespec-azure-portal-core": "0.44.0",
+    "@azure-tools/typespec-azure-resource-manager": "0.44.0",
+    "@azure-tools/typespec-azure-rulesets": "0.44.0",
     "@azure-tools/typespec-client-generator-cli": "0.9.3",
-    "@azure-tools/typespec-client-generator-core": "0.43.0",
+    "@azure-tools/typespec-client-generator-core": "0.44.0",
     "@azure/avocado": "^0.8.4",
-    "@typespec/compiler": "0.57.0",
-    "@typespec/http": "0.57.0",
-    "@typespec/openapi": "0.57.0",
-    "@typespec/openapi3": "0.57.0",
-    "@typespec/rest": "0.57.0",
-    "@typespec/versioning": "0.57.0",
+    "@typespec/compiler": "0.58.1",
+    "@typespec/http": "0.58.0",
+    "@typespec/openapi": "0.58.0",
+    "@typespec/openapi3": "0.58.0",
+    "@typespec/rest": "0.58.0",
+    "@typespec/versioning": "0.58.0",
     "azure-rest-api-specs-eng-tools": "file:eng/tools",
     "oav": "^3.3.7",
     "prettier": "~3.2.5",

specification/apicenter/ApiCenter.Management/Service.tsp

@@ -29,7 +29,13 @@ interface Services {
   @doc("Creates new or updates existing API.")
   createOrUpdate is Azure.ResourceManager.ArmResourceCreateOrReplaceSync<Service>;
   @doc("Updates existing service.")
-  update is ArmResourcePatchSync<Service, ServiceProperties>;
+  update is ArmCustomPatchSync<
+    Service,
+    Azure.ResourceManager.Foundations.ResourceUpdateModel<
+      Service,
+      ServiceProperties
+    >
+  >;
   @doc("Deletes specified service.")
   delete is ArmResourceDeleteSync<Service>;
   @doc("Returns a collection of services within the resource group.")

specification/apicenter/ApiCenter.Management/tspconfig.yaml

@@ -4,6 +4,9 @@ options:
   "@azure-tools/typespec-autorest":
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/apicenter.json"
     examples-directory: "{project-root}/examples"
     use-read-only-status-schema: true

specification/apicenter/resource-manager/Microsoft.ApiCenter/preview/2024-03-15-preview/apicenter.json

@@ -4817,6 +4817,7 @@
         },
         "properties": {
           "$ref": "#/definitions/ServiceUpdateProperties",
+          "description": "The resource-specific properties for this resource.",
           "x-ms-client-flatten": true
         }
       }

specification/appcomplianceautomation/AppComplianceAutomation.Management/tspconfig.yaml

@@ -11,6 +11,9 @@ options:
     use-read-only-status-schema: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/appcomplianceautomation.json"
     examples-directory: "{project-root}/examples"
   "@azure-tools/typespec-ts":

specification/azurefleet/AzureFleet.Management/tspconfig.yaml

@@ -13,6 +13,9 @@ options:
     use-read-only-status-schema: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/azurefleet.json"
     examples-directory: "examples"
   "@azure-tools/typespec-csharp":

specification/azurefleet/resource-manager/Microsoft.AzureFleet/preview/2023-11-01-preview/azurefleet.json

@@ -486,42 +486,6 @@
     }
   },
   "definitions": {
-    "Azure.ResourceManager.CommonTypes.ManagedServiceIdentityType": {
-      "type": "string",
-      "description": "Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed).",
-      "enum": [
-        "None",
-        "SystemAssigned",
-        "UserAssigned",
-        "SystemAssigned,UserAssigned"
-      ],
-      "x-ms-enum": {
-        "name": "ManagedServiceIdentityType",
-        "modelAsString": true,
-        "values": [
-          {
-            "name": "None",
-            "value": "None",
-            "description": "No managed identity."
-          },
-          {
-            "name": "SystemAssigned",
-            "value": "SystemAssigned",
-            "description": "System assigned managed identity."
-          },
-          {
-            "name": "UserAssigned",
-            "value": "UserAssigned",
-            "description": "User assigned managed identity."
-          },
-          {
-            "name": "SystemAndUserAssigned",
-            "value": "SystemAssigned,UserAssigned",
-            "description": "System and user assigned managed identity."
-          }
-        ]
-      }
-    },
     "BasePriorityProfile": {
       "type": "object",
       "description": "Contains common properties that are applicable to both Spot and Regular.",
@@ -738,15 +702,20 @@
       "description": "The template for adding optional properties.",
       "properties": {
         "type": {
-          "$ref": "#/definitions/Azure.ResourceManager.CommonTypes.ManagedServiceIdentityType",
+          "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentityType",
           "description": "The type of managed identity assigned to this resource."
         },
         "userAssignedIdentities": {
           "type": "object",
           "description": "The identities assigned to this resource by the user.",
-          "x-nullable": true,
           "additionalProperties": {
-            "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/UserAssignedIdentity"
+            "allOf": [
+              {
+                "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/UserAssignedIdentity"
+              }
+            ],
+            "type": "object",
+            "x-nullable": true
           }
         }
       }

specification/azurefleet/resource-manager/Microsoft.AzureFleet/preview/2024-05-01-preview/azurefleet.json

@@ -465,42 +465,6 @@
     }
   },
   "definitions": {
-    "Azure.ResourceManager.CommonTypes.ManagedServiceIdentityType": {
-      "type": "string",
-      "description": "Type of managed service identity (where both SystemAssigned and UserAssigned types are allowed).",
-      "enum": [
-        "None",
-        "SystemAssigned",
-        "UserAssigned",
-        "SystemAssigned,UserAssigned"
-      ],
-      "x-ms-enum": {
-        "name": "ManagedServiceIdentityType",
-        "modelAsString": true,
-        "values": [
-          {
-            "name": "None",
-            "value": "None",
-            "description": "No managed identity."
-          },
-          {
-            "name": "SystemAssigned",
-            "value": "SystemAssigned",
-            "description": "System assigned managed identity."
-          },
-          {
-            "name": "UserAssigned",
-            "value": "UserAssigned",
-            "description": "User assigned managed identity."
-          },
-          {
-            "name": "SystemAndUserAssigned",
-            "value": "SystemAssigned,UserAssigned",
-            "description": "System and user assigned managed identity."
-          }
-        ]
-      }
-    },
     "BasePriorityProfile": {
       "type": "object",
       "description": "Contains common properties that are applicable to both Spot and Regular.",
@@ -727,15 +691,20 @@
       "description": "The template for adding optional properties.",
       "properties": {
         "type": {
-          "$ref": "#/definitions/Azure.ResourceManager.CommonTypes.ManagedServiceIdentityType",
+          "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/ManagedServiceIdentityType",
           "description": "The type of managed identity assigned to this resource."
         },
         "userAssignedIdentities": {
           "type": "object",
           "description": "The identities assigned to this resource by the user.",
-          "x-nullable": true,
           "additionalProperties": {
-            "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/UserAssignedIdentity"
+            "allOf": [
+              {
+                "$ref": "../../../../../common-types/resource-management/v5/managedidentity.json#/definitions/UserAssignedIdentity"
+              }
+            ],
+            "type": "object",
+            "x-nullable": true
           }
         }
       }

specification/azurelargeinstance/AzureLargeInstance.Management/tspconfig.yaml

@@ -7,6 +7,9 @@ options:
   "@azure-tools/typespec-autorest":
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/azurelargeinstance.json"
     examples-directory: "{project-root}/examples"
     use-read-only-status-schema: true

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/GalleryImages.tsp

@@ -49,7 +49,7 @@ interface GalleryImages {
   delete is ArmResourceDeleteWithoutOkAsync<GalleryImage>;
 
   @doc("Lists all of the gallery images in the specified resource group. Use the nextLink property in the response to get the next page of gallery images.")
-  list is ArmResourceListByParent<GalleryImage>;
+  listByResourceGroup is ArmResourceListByParent<GalleryImage>;
 
   @doc("Lists all of the gallery images in the specified subscription. Use the nextLink property in the response to get the next page of gallery images.")
   listAll is ArmListBySubscription<GalleryImage>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/GuestAgent.tsp

@@ -42,5 +42,5 @@ interface GuestAgents {
   delete is ArmResourceDeleteWithoutOkAsync<GuestAgent>;
 
   @doc("Returns the list of GuestAgent of the given vm.")
-  list is ArmResourceListByParent<GuestAgent>;
+  listByVirtualMachineInstance is ArmResourceListByParent<GuestAgent>;
 }

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/HybridIdentityMetadata.tsp

@@ -36,5 +36,5 @@ interface HybridIdentityMetadataGroup {
   get is ArmResourceRead<HybridIdentityMetadata>;
 
   @doc("Returns the list of HybridIdentityMetadata of the given vm.")
-  list is ArmResourceListByParent<HybridIdentityMetadata>;
+  listByVirtualMachineInstance is ArmResourceListByParent<HybridIdentityMetadata>;
 }

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/LogicalNetworks.tsp

@@ -49,7 +49,7 @@ interface LogicalNetworks {
   delete is ArmResourceDeleteWithoutOkAsync<LogicalNetwork>;
 
   @doc("Lists all of the logical networks in the specified resource group. Use the nextLink property in the response to get the next page of logical networks.")
-  list is ArmResourceListByParent<LogicalNetwork>;
+  listByResourceGroup is ArmResourceListByParent<LogicalNetwork>;
 
   @doc("Lists all of the logical networks in the specified subscription. Use the nextLink property in the response to get the next page of logical networks.")
   listAll is ArmListBySubscription<LogicalNetwork>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/MarketplaceGalleryImages.tsp

@@ -50,7 +50,7 @@ interface MarketplaceGalleryImages {
   delete is ArmResourceDeleteWithoutOkAsync<MarketplaceGalleryImage>;
 
   @doc("Lists all of the marketplace gallery images in the specified resource group. Use the nextLink property in the response to get the next page of marketplace gallery images.")
-  list is ArmResourceListByParent<MarketplaceGalleryImage>;
+  listByResourceGroup is ArmResourceListByParent<MarketplaceGalleryImage>;
 
   @doc("Lists all of the marketplace gallery images in the specified subscription. Use the nextLink property in the response to get the next page of marketplace gallery images.")
   listAll is ArmListBySubscription<MarketplaceGalleryImage>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/NetworkInterfaces.tsp

@@ -49,7 +49,7 @@ interface NetworkInterfaces {
   delete is ArmResourceDeleteWithoutOkAsync<NetworkInterface>;
 
   @doc("Lists all of the network interfaces in the specified resource group. Use the nextLink property in the response to get the next page of network interfaces.")
-  list is ArmResourceListByParent<NetworkInterface>;
+  listByResourceGroup is ArmResourceListByParent<NetworkInterface>;
 
   @doc("Lists all of the network interfaces in the specified subscription. Use the nextLink property in the response to get the next page of network interfaces.")
   listAll is ArmListBySubscription<NetworkInterface>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/NetworkSecurityGroups.tsp

@@ -46,7 +46,7 @@ interface NetworkSecurityGroups {
   delete is ArmResourceDeleteWithoutOkAsync<NetworkSecurityGroup>;
 
   @doc("Gets all network security groups in a resource group.")
-  list is ArmResourceListByParent<NetworkSecurityGroup>;
+  listByResourceGroup is ArmResourceListByParent<NetworkSecurityGroup>;
 
   @doc("Gets all network security groups in a subscription.")
   listAll is ArmListBySubscription<NetworkSecurityGroup>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/SecurityRules.tsp

@@ -42,5 +42,5 @@ interface SecurityRules {
   delete is ArmResourceDeleteWithoutOkAsync<SecurityRule>;
 
   @doc("Gets all security rules in a Network Security Group.")
-  list is ArmResourceListByParent<SecurityRule>;
+  listByNetworkSecurityGroup is ArmResourceListByParent<SecurityRule>;
 }

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/StorageContainers.tsp

@@ -47,7 +47,7 @@ interface StorageContainers {
   delete is ArmResourceDeleteWithoutOkAsync<StorageContainer>;
 
   @doc("Lists all of the storage containers in the specified resource group. Use the nextLink property in the response to get the next page of storage containers.")
-  list is ArmResourceListByParent<StorageContainer>;
+  listByResourceGroup is ArmResourceListByParent<StorageContainer>;
 
   @doc("Lists all of the storage containers in the specified subscription. Use the nextLink property in the response to get the next page of storage containers.")
   listAll is ArmListBySubscription<StorageContainer>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/VirtualHardDisks.tsp

@@ -48,7 +48,7 @@ interface VirtualHardDisks {
   delete is ArmResourceDeleteWithoutOkAsync<VirtualHardDisk>;
 
   @doc("Lists all of the virtual hard disks in the specified resource group. Use the nextLink property in the response to get the next page of virtual hard disks.")
-  list is ArmResourceListByParent<VirtualHardDisk>;
+  listByResourceGroup is ArmResourceListByParent<VirtualHardDisk>;
 
   @doc("Lists all of the virtual hard disks in the specified subscription. Use the nextLink property in the response to get the next page of virtual hard disks.")
   listAll is ArmListBySubscription<VirtualHardDisk>;

specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml

@@ -5,6 +5,9 @@ options:
     use-read-only-status-schema: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/StackHCIVM/{version-status}/{version}/stackhcivm.json"
     examples-directory: "{project-root}/examples"
 linter:

specification/azurestackhci/Operations.Management/tspconfig.yaml

@@ -5,6 +5,9 @@ options:
     use-read-only-status-schema: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/operations/{version-status}/{version}/operations.json"
     examples-directory: "{project-root}/examples"
 linter:

specification/codesigning/CodeSigning.Management/tspconfig.yaml

@@ -5,6 +5,9 @@ options:
     use-read-only-status-schema: true
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/codeSigningAccount.json"
     examples-directory: "{project-root}/examples"
 linter:

specification/communitytraining/Community.Management/main.tsp

@@ -144,9 +144,12 @@ interface CommunityTrainings {
     CommunityTraining,
     LroHeaders = Azure.Core.Foundations.RetryAfterHeader
   >;
-  update is ArmResourcePatchAsync<
+  update is ArmCustomPatchAsync<
     CommunityTraining,
-    CommunityTrainingProperties
+    Azure.ResourceManager.Foundations.ResourceUpdateModel<
+      CommunityTraining,
+      CommunityTrainingProperties
+    >
   >;
   delete is ArmResourceDeleteAsync<CommunityTraining>;
   listByResourceGroup is ArmResourceListByParent<CommunityTraining>;

specification/communitytraining/Community.Management/tspconfig.yaml

@@ -4,6 +4,9 @@ options:
   "@azure-tools/typespec-autorest":
     emitter-output-dir: "{project-root}/.."
     azure-resource-provider-folder: "resource-manager"
+    emit-common-types-schema: "never"
+    # `arm-resource-flattening` is only used for back-compat for specs existed on July 2024. All new service spec should NOT use this flag
+    arm-resource-flattening: true
     output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/CommunityTrainings.json"
     examples-directory: "{project-root}/examples"
 linter:

specification/communitytraining/resource-manager/Microsoft.Community/stable/2023-11-01/CommunityTrainings.json

@@ -553,6 +553,7 @@
         },
         "properties": {
           "$ref": "#/definitions/CommunityTrainingUpdateProperties",
+          "description": "The resource-specific properties for this resource.",
           "x-ms-client-flatten": true
         }
       }