ipmi_si: Fix wrong return value in try_smi_init()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 90b2d4f ("ipmi_si: Remove hacks for adding a dummy platform devices") Cc: Corey Minyard <[email protected]> Signed-off-by: Tianjia Zhang <[email protected]> Message-Id: <[email protected]> Signed-off-by: Corey Minyard <[email protected]>
zandrey · Oct 5, 2020 · 8fe7990 · 8fe7990
1 parent c011410
commit 8fe7990
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1980,7 +1980,7 @@ static int try_smi_init(struct smi_info *new_smi)
 	/* Do this early so it's available for logs. */
 	if (!new_smi->io.dev) {
 		pr_err("IPMI interface added with no device\n");
-		rv = EIO;
+		rv = -EIO;
 		goto out_err;
 	}