gpio: siox: explicitly support only threaded irqs

The gpio-siox driver uses handle_nested_irq() to implement its interrupt support. This is only capable of handling threaded irq actions. For a hardirq action it triggers a NULL pointer oops. (It calls action->thread_fn which is NULL then.) Prevent registration of a hardirq action by setting gpio_irq_chip::threaded to true. Cc: [email protected] Fixes: be8c8fa ("gpio: new driver to work with a 8x12 siox") Cc: [email protected] Signed-off-by: Ahmad Fatoum <[email protected]> Acked-by: Uwe Kleine-König <[email protected]> Signed-off-by: Bartosz Golaszewski <[email protected]>
zandrey · Sep 9, 2020 · 45ccf65 · 45ccf65
1 parent 214b0e1
commit 45ccf65
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/drivers/gpio/gpio-siox.c b/drivers/gpio/gpio-siox.c
@@ -245,6 +245,7 @@ static int gpio_siox_probe(struct siox_device *sdevice)
 	girq->chip = &ddata->ichip;
 	girq->default_type = IRQ_TYPE_NONE;
 	girq->handler = handle_level_irq;
+	girq->threaded = true;
 
 	ret = devm_gpiochip_add_data(dev, &ddata->gchip, NULL);
 	if (ret)