Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to specify custom volumes and volumeMounts for Zammad Pods #272

Merged
merged 4 commits into from
May 8, 2024

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented May 2, 2024

Which issue this PR fixes

Special notes for your reviewer

  • Includes self-tests for the new feature and adds new capabilities to specify Rails code to be run inside helm test.

Checklist

  • Chart Version bumped

@mgruner mgruner mentioned this pull request May 2, 2024
@mgruner mgruner requested a review from monotek May 3, 2024 05:45
@mgruner
Copy link
Collaborator Author

mgruner commented May 8, 2024

@klml are these changes on the kubernetes level good for you? I would like to merge them as they seem to be generally useful and we need them also for the testing extensions.

@mgruner
Copy link
Collaborator Author

mgruner commented May 8, 2024

Confirmation of @klml received via @t-shehab, so I will proceed.

@mgruner mgruner merged commit 9a940ce into main May 8, 2024
10 checks passed
@mgruner mgruner deleted the custom-volumes branch May 8, 2024 11:37
@klml
Copy link
Contributor

klml commented May 8, 2024

@mgruner sorry for ma delay, but all works fine

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration as code
3 participants