Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static names for container-name #265

Closed
klml opened this issue Apr 26, 2024 · 3 comments · Fixed by #269
Closed

static names for container-name #265

klml opened this issue Apr 26, 2024 · 3 comments · Fixed by #269

Comments

@klml
Copy link
Contributor

klml commented Apr 26, 2024

Currently we are using dynamic container-name (eg name: {{ .Chart.Name }}-nginx This is sometimes confusing.

Version of Helm and Kubernetes:

zammad-12.0.0

What you expected to happen:

static container names

Anything else we need to know:

@monotek

@mgruner
Copy link
Collaborator

mgruner commented Apr 26, 2024

Isn't the dynamic naming by design @klml? With every Helm install, the application is given a name. This should be reflected in the objects to make it possible that instances of the same application can coexist, which would not work with static names. Or did I miss something here?

I agree about the inconsistency and the bug in ingress, we should definitely improve that.

@monotek
Copy link
Member

monotek commented Apr 26, 2024

Yes, the k8s resources itself should take over at least parts of the name of the release name, so the same chart can be installed multiple times in the same namespace.

The names inside the resources, like containernames, could be static.
Sometimes helm create usese the "{{ .Chart.Name }}" var by default, which should not change but if there are some names which use the "fullname" var and some are static we should allign that.

@klml
Copy link
Contributor Author

klml commented Apr 26, 2024

@mgruner you are right

I agree about the inconsistency and the bug in ingress, we should definitely improve that.

I moved this to #268 and ....

@monotek you are also right ;)

...so the same chart can be installed multiple times in the same namespace.

so I redescribed this issue as only "container-name" and optional

@klml klml changed the title static names for kubernetes objects static names for container-name Apr 26, 2024
mgruner added a commit that referenced this issue Apr 29, 2024
Fixes: #265 - static names for container-name
Fixes: #268 - inconsistency static ingress and dynamic svc
mgruner added a commit that referenced this issue Apr 29, 2024
* Fix ingress configuration and use static container names.
* Consistently prefer 'include' over 'template'.

Fixes: #265 - static names for container-name
Fixes: #268 - inconsistency static ingress and dynamic svc

Co-authored-by: André Bauer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants