Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace reencrypt by decrypt #160

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore: replace reencrypt by decrypt #160

merged 1 commit into from
Jan 6, 2025

Conversation

immortal-tofu
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jan 3, 2025
@immortal-tofu immortal-tofu requested a review from jatZama January 3, 2025 13:12
@jatZama
Copy link
Member

jatZama commented Jan 4, 2025 •
edited
Loading

Ok but what about the new name for debug.decryptXX then? we still need to agree on a new nomenclature there to avoid confusion. Maybe debug.forceDecryptXX ?

@immortal-tofu
Copy link
Collaborator Author

debug.decrypt32 is self explicit about the fact this is a debug function. No need to change that.

@jatZama
Copy link
Member

jatZama commented Jan 4, 2025

Unless the FHEVMInstance is itself called debug but I guess whatever.

@immortal-tofu immortal-tofu merged commit 1802146 into main Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatZama jatZama jatZama approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@immortal-tofu @jatZama