Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension always detect redux library in every page #600

Closed
vitomanu96 opened this issue Nov 30, 2018 · 4 comments
Closed

extension always detect redux library in every page #600

vitomanu96 opened this issue Nov 30, 2018 · 4 comments

Comments

@vitomanu96
Copy link

vitomanu96 commented Nov 30, 2018

the extension icon is always lighting up for every page I visit.

@zalmoxisus
Copy link
Owner

Could you please provide more details? That would be an issue if it won't always detect it)

@ChrisYGarcia
Copy link

Having this same issue; the extension icon is always lighting up for every page I visit.

@zalmoxisus
Copy link
Owner

zalmoxisus commented Dec 1, 2018

Thanks for clarifying that it's about the icon. Yes, I've seen it in Canary that page action icon is not faded (grayed) anymore by Chrome in latest version, however it's still inactive. I rechecked chrome.pageAction.show is not called from our side when not needed.

Not sure if it's a bug or a feature in new versions of Chrome. What is strange is that it is still grayed out on about-blank and chrome:// pages.

A solution would be to provide our gray icon and change it from our side, same as React DevTools does (the difference is that it uses browser action, not page action, which wasn't faded before).

@zalmoxisus
Copy link
Owner

It should be fixed in 2.16.5 which is available on Chrome Store. We are adding a gray icon by default and changing when the store is initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants