time travel isn't working when using the redux-batched-subscribe store enhancer

[borisirota]

Hi, any idea why the time travel isn't working when using the redux-batched-subscribe store enhancer ?

Thanks

[zalmoxisus]

Hi. Could you please provide an example repo or jsfiddle? I'd look into it.

[borisirota]

https://github.com/borisirota/redux-batched-subscribe-dev-tools-issue

Thanks !

[zalmoxisus]

@borisirota, thanks for the example.

There's no problems with redux-batched-subscribe, just the orders of the enhancers matters. So, time travelling actually works, but redux-batched-subscribe is not aware of that action (and react-redux listener is not called). To get React updated with those changes you have to emit another action.

The solution is not to use composeWithDevTools, which assures the extension's enhancer to be the last in compose (which is not the case of redux-batched-subscribe), but to use it like so:

  const store = createStore(reducer, preloadedState, compose(
    // applyMiddleware(thunk),
    window.__REDUX_DEVTOOLS_EXTENSION__ ? window.__REDUX_DEVTOOLS_EXTENSION__() : noop => noop,
    batchedSubscribe((notify) => notify())
  ));

So redux-batched-subscribe will be after the extension's enhancer and will be aware of its actions.

Note that there will be no need for that noop function in the next version of Redux thanks to reduxjs/redux#2073.

[borisirota]

it works ! great ! thanks a lot !!! 👍

[zalmoxisus]

You're welcome. Added a note about it in Troubleshooting.