Provide confidential values as secret #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use existingSecretName to configure secret via external secret - rabbitmq uses its own naming syntax. We show them for convenience - fixing external database property Postgres secrets for external databases has to be added still
mwallschlaeger
requested changes
Sep 8, 2023
| @@ -65,6 +65,8 @@ spec: | |||
| envFrom: | |||
| - configMapRef: | |||
| name: {{ include "geoserver_pod_name" . }}-env | |||
| - secretRef: | |||
| name: {{ .Values.geoserver.secret.existingSecretName | "geoserver-secret" | quote }} | |||
There was a problem hiding this comment.
See comments on geonode-deploy.yaml herefor
mwallschlaeger
previously approved these changes
Sep 8, 2023
mwallschlaeger
added
documentation
ridoo
changed the title
ridoo
commented
Sep 8, 2023
charts/geonode/templates/postgres/postgres-external-geonode-secrets.yaml
Outdated
Show resolved
Hide resolved
mwallschlaeger
requested changes
Sep 8, 2023
mwallschlaeger
approved these changes
Sep 10, 2023
mwallschlaeger
added a commit
that referenced
this pull request
Sep 11, 2023
* Issue#59 task prepare this repository to be available on artifact hub (#65) * Fixes [#59,#58] * Issue#27 py csw single microservice (#68) issue#27_csw_single_microsservice * Issue#67 separate site url related settings from ingress config (#69) issue#67_separate_site_url_related_settings_from_ingress_config * Provide confidential values as secret (#71) * WIP: Provide confidential values as secret * Fix parameter names in comment * Provide demo credentials as base64 * Add named secret in values.yaml with default content * Remove secret boilerplate in values.yaml * Configure secret creation via flag * Enhance secret configuration - Use existingSecretName to configure secret via external secret - rabbitmq uses its own naming syntax. We show them for convenience - fixing external database property Postgres secrets for external databases has to be added still * Fix yaml syntax * Fix yaml and property refs * Adds configurable secret to external database * Adjust minikube values * Resolve go template issues * Update documentation * Fix wording * release 1.0.0 final changes [geonode 4.1.2] (#74) release 1.0.0 * Issue#72 bug celery container is not starting properly and exiting right away (#76) * release 1.0.0 * fixing release build (#78) * added github token to install helm --------- Co-authored-by: Henning Bredel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates confidential values (currently the superuser credentials) from
values.yamlinto a Kubernetes Secret.Provides a
templates/demo-secret.yamlby default. However, can be overridden by a custom secret which can be referenced by name in thevalues.yaml.@mwallschlaeger please have a look, if you think this is a path we may want to follow. If you are ok, I will continue refactoring the remaining credentials.
Type of Change
Please select the relevant option:
Related Issue
If there is an existing issue related to this pull request, please reference it here.
closes #70
Checklist
Please ensure that your pull request meets the following requirements:
Additional Notes
Any additional information or context regarding the pull request can be provided here.
Thank you for creating this pull request