This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Improve logging by introducing slf4j and logback #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 28, 2018 10:05
Codecov Report
@@ Coverage Diff @@
## merge-501 #501 +/- ##
===============================================
+ Coverage 80.27% 80.45% +0.18%
- Complexity 572 578 +6
===============================================
Files 32 32
Lines 2662 2656 -6
Branches 232 232
===============================================
Hits 2137 2137
+ Misses 384 378 -6
Partials 141 141 |
|
Thanks @dennisgranath for this PR! |
diemol
reviewed
Mar 28, 2018
| @@ -260,32 +287,7 @@ | |||
| </filter> | |||
| </filters> | |||
| <artifactSet> | |||
There was a problem hiding this comment.
This makes so much sense! I don't know how we overlooked that :) Thanks!
|
Merging to a protected branch to run CI tests. |
Merged
dennisgranath
commented
Mar 29, 2018
| @@ -16,8 +16,7 @@ | |||
| # By default we only configure a ConsoleHandler, which will only | |||
| # show messages at the INFO and above levels. | |||
| #handlers= java.util.logging.ConsoleHandler | |||
| handlers= java.util.logging.FileHandler, java.util.logging.ConsoleHandler | |||
|
|
|||
| handlers = org.slf4j.bridge.SLF4JBridgeHandler | |||
There was a problem hiding this comment.
Just one note here. If someone is dependent on that logs are written to a file I think we need to add an optional filehandler in logback.xml.
diemol
added a commit
that referenced
this pull request
Mar 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change logging from java util logging (jul) to slf4j. Add option to log in jsonFormat with command line argument --logJson. All "native" selenium logs are sent to logback using jul-to-slf4j by setting the SLF4JBridgeHandler (logging_info.properties). In order to that in a smooth way i added the selenium jar into the resulting zalenium.jar.
Motivation and Context
We would like to be able to log in json output and add support for MDC (mapped diagnotic context). Using this approach one could build dashboards in tools like for example kibana.
How Has This Been Tested?
Types of changes
Checklist: