This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
fix assets preload for primary fragments on aws s3 (#228) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
|
@vigneshshanmugam have a look, too? |
|
@guilhermecvm Thanks for the PR, can you add a test in this section https://github.com/zalando/tailor/blob/master/tests/tailor.js#L367? |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=====================================
Coverage 99% 99%
=====================================
Files 15 15
Lines 603 603
Branches 112 112
=====================================
Hits 597 597
Misses 6 6
Continue to review full report at Codecov.
|
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to aws custom headers when preloading assets.