Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

set ENABLE_BITCODE=No to be compatible wite xcode8.3 #26

Merged
merged 1 commit into from
May 30, 2017

Conversation

lina1
Copy link

@lina1 lina1 commented Apr 10, 2017

No description provided.

@lina1
Copy link
Author

lina1 commented Apr 10, 2017

After xcode upgrade to 8.3, the ENABLE_BITCODE will be set to Yes by default, then the monkey test cannot run on real device, so ENABLE_BITCODE should be set to No explicitly in SwiftMonkey.

@lasomethingsomething
Copy link

@lina1, thank you for the PR. @DagAgren, can you please take a look and get back to this potential contributor?

@wojciechczerski
Copy link
Member

👍

@m619
Copy link

m619 commented May 26, 2017

👍

@wojciechczerski
Copy link
Member

@DagAgren @LappleApple Could you please have a look / merge this PR?

@DagAgren
Copy link
Collaborator

If you have tested that it works, feel free to merge it yourself. Do you have access to do it?

@wojciechczerski
Copy link
Member

@DagAgren I do not have the permission to do so, but I did test the change.

@lasomethingsomething lasomethingsomething merged commit fc95fe8 into zalando:master May 30, 2017
@lasomethingsomething
Copy link

@wojciechczerski: I've made you an admin

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants