Fix testing pipeline #580
Merged
Fix testing pipeline #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hughcapet
commented
Feb 28, 2023
•
hughcapet
commented
- CDP overlays -> runtime
- Remove top-level region option
- Define a separate Command class for flake8 in setup.py (flake8 setuptools/setup.py support is now deprecated)
- Fix a flake8 error
hughcapet
force-pushed
the
ci/fix-pipeline
branch
6 times, most recently
from
f222900 to
16f4d4f
Compare
The current implementation uses value set via the envvar AWS_DEFAULT_REGION for sub-commands even if an explicit flag value is provided. This commit also integrates get_region() into the 'region' option's callback, so that senza first ensures a non-empty region value (gets region from "~/.aws/config" if nothing is provided) and then validates it against the available regions list.
As flake8 support for setup.py has been removed
hughcapet
force-pushed
the
ci/fix-pipeline
branch
from
16f4d4f to
e1bc0f5
Compare
|
👍 |
|
LGTM but I've a question. Why are you removing the top-level region option? |
|
sorry, should have posted the message from one of the commits. This is because this was causing the following misbehavior (revealed in the And I actually don't fully understand the whole idea of having the top-level region option. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.