Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VPA update permissions #5375

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix VPA update permissions #5375

merged 1 commit into from
Sep 20, 2022

Conversation

mikkeloscar
Copy link
Contributor

Follow up to #5361 adding missing permissions

Without this we get the following errors for vpa-admission-controller and vpa-updater.

Status update by vpa-admission-controller-65cf6c86db-9wzbk failed: leases.coordination.k8s.io "vpa-admission-controller" is forbidden: User "system:serviceaccount:kube-system:vpa-admission-controller" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "kube-system": access undecided system:serviceaccount:kube-system:vpa-admission-controller/[system:serviceaccounts system:serviceaccounts:kube-system system:authenticated]

@mikkeloscar
Fix VPA update permissions
7dc271c 
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@demonCoder95
Copy link
Member

Thanks for the patch! 🙏

@demonCoder95
Copy link
Member

👍

1 similar comment
@mikkeloscar
Copy link
Contributor Author

👍

@mikkeloscar mikkeloscar merged commit be34f95 into dev Sep 20, 2022
@mikkeloscar mikkeloscar deleted the vpa-permissions-fix branch September 20, 2022 13:48
This was referenced Sep 20, 2022
Merged
Merged
@zalando-teapot-robot zalando-teapot-robot mentioned this pull request Sep 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged/alpha merged/beta merged/stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkeloscar @demonCoder95 @zalando-teapot-robot