Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alpha to beta #4944

Merged
merged 17 commits into from
Jan 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c303225
Step 2 of consolidating Prometheus
mikkeloscar Jan 25, 2022
75a9d76
Merge pull request #4934 from zalando-incubator/prometheus-consolidat…
mikkeloscar Jan 26, 2022
9c690d4
Merge dev to dev-to-alpha
zalando-teapot-robot Jan 26, 2022
07957f1
skipper/routesrv: Delete routesrv deployment when not enabled
AlexanderYastrebov Jan 26, 2022
a665be2
admission-controller: update version to support setting replicas from…
AlexanderYastrebov Jan 26, 2022
10f0ea0
Merge pull request #4937 from zalando-incubator/disable-routesrv
mikkeloscar Jan 26, 2022
fb5f345
Merge dev to dev-to-alpha
zalando-teapot-robot Jan 26, 2022
f4624eb
Change cluster-id tag prefix for egress stack
mikkeloscar Jan 26, 2022
092c08b
Merge pull request #4938 from zalando-incubator/update-admission-cont…
AlexanderYastrebov Jan 26, 2022
f277de8
Merge dev to dev-to-alpha
zalando-teapot-robot Jan 26, 2022
a388880
Merge pull request #4939 from zalando-incubator/egress-controller-clu…
gargravarr Jan 27, 2022
26cb036
Merge dev to dev-to-alpha
zalando-teapot-robot Jan 27, 2022
d4f18a1
ingress/routesrv: Makes skipper_routesrv_enabled a three state switch
AlexanderYastrebov Jan 26, 2022
d9b3847
Merge pull request #4940 from zalando-incubator/routesrv-three-state-…
AlexanderYastrebov Jan 27, 2022
4431a58
Merge dev to dev-to-alpha
zalando-teapot-robot Jan 27, 2022
2efe2ad
Merge pull request #4935 from zalando-incubator/dev-to-alpha
mikkeloscar Jan 28, 2022
1af2d75
Merge alpha to alpha-to-beta
zalando-teapot-robot Jan 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cluster/config-defaults.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,20 @@ skipper_redis_write_timeout: "25ms"

skipper_cluster_ratelimit_max_group_shards: 1

#
# skipper routesrv settings
#
# skipper_routesrv_enabled is a three state switch:
# - "false" - routesrv deployment is removed, skipper uses own k8s dataclient
# - "pre" - routesrv is deployed, skipper uses own k8s dataclient
# - "exec" - routesrv is deployed, skipper uses routesrv
{{if eq .Cluster.Environment "production"}}
skipper_routesrv_enabled: "false"
skipper_routesrv_replicas: 3
skipper_routesrv_cpu: "1000m"
skipper_routesrv_memory: "1Gi"
{{else}}
skipper_routesrv_enabled: "true"
skipper_routesrv_enabled: "false"
skipper_routesrv_replicas: 3
skipper_routesrv_cpu: "100m"
skipper_routesrv_memory: "1Gi"
Expand Down
16 changes: 11 additions & 5 deletions cluster/manifests/deletions.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ pre_apply:
# kind: DaemonSet
# propagation_policy: Orphan
# step 2 (prometheus consolidation)
# - labels:
# application: prometheus
# namespace: kube-system
# kind: StatefulSet
# propagation_policy: Orphan
- labels:
application: prometheus
namespace: kube-system
kind: StatefulSet
propagation_policy: Orphan

# everything defined under here will be deleted after applying the manifests
post_apply:
Expand Down Expand Up @@ -129,3 +129,9 @@ post_apply:
- name: cluster-admin-okta
kind: ClusterRoleBinding
{{- end }}

{{ if eq .Cluster.ConfigItems.skipper_routesrv_enabled "false" }}
- name: skipper-ingress-routesrv
namespace: kube-system
kind: Deployment
{{ end }}
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ spec:
{{ end }}
- "--stack-termination-protection"
- "--cluster-id={{ .ID }}"
- "--cluster-id-tag-prefix=zalando.org/cluster/"
- "--additional-stack-tags=InfrastructureComponent=true"
- "--additional-stack-tags=zalando.org/cluster/{{ .Cluster.ID }}=owned"
env:
- name: AWS_REGION
value: {{ .Cluster.Region }}
Expand Down
6 changes: 2 additions & 4 deletions cluster/manifests/prometheus/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@ metadata:
annotations:
pdb-controller.zalando.org/non-ready-ttl: "5m"
labels:
application: prometheus
# application: kubernetes # step 2
application: kubernetes
component: prometheus
version: v2.32.1
{{- if ne .ConfigItems.prometheus_csi_ebs "true" }}
Expand All @@ -19,8 +18,7 @@ spec:
podManagementPolicy: Parallel
selector:
matchLabels:
application: prometheus
# statefulset: prometheus # step 2
statefulset: prometheus
serviceName: prometheus
template:
metadata:
Expand Down
12 changes: 6 additions & 6 deletions cluster/manifests/skipper/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ spec:
args:
- "run.sh"
- "skipper"
{{ if eq .ConfigItems.skipper_routesrv_enabled "true" }}
{{ if eq .ConfigItems.skipper_routesrv_enabled "exec" }}
- "-routes-urls=http://skipper-ingress-routesrv.kube-system.svc.cluster.local/routes"
- "-normalize-host"
{{ else }}
Expand All @@ -103,11 +103,11 @@ spec:
- "-address=:9999"
- "-wait-first-route-load"
- "-wait-for-healthcheck-interval={{ .Cluster.ConfigItems.skipper_wait_for_healthcheck_interval }}"
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "true") (eq .ConfigItems.enable_skipper_eastwest "true")}}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "exec") (eq .ConfigItems.enable_skipper_eastwest "true")}}
- "-enable-kubernetes-east-west"
- "-kubernetes-east-west-domain=.ingress.cluster.local"
{{ end }}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "true") (eq .ConfigItems.enable_skipper_eastwest_range "true")}}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "exec") (eq .ConfigItems.enable_skipper_eastwest_range "true")}}
- "-kubernetes-east-west-range-domains=ingress.cluster.local"
- "-kubernetes-east-west-range-predicates=ClientIP(\"10.2.0.0/16\", \"{{ .Values.vpc_ipv4_cidr }}\")"
{{ end }}
Expand Down Expand Up @@ -135,7 +135,7 @@ spec:
- "-api-usage-monitoring-client-keys=https://identity.zalando.com/managed-id,sub"
- "-api-usage-monitoring-default-client-tracking-pattern=services[.].*"
{{ end }}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "true") (eq .ConfigItems.enable_apimonitoring "true")}}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "exec") (eq .ConfigItems.enable_apimonitoring "true")}}
- "-default-filters-dir=/etc/config/default-filters"
{{ end }}
- "-max-audit-body=0"
Expand Down Expand Up @@ -275,7 +275,7 @@ spec:
- name: routes
mountPath: /etc/routes
{{ end }}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "true") (eq .ConfigItems.enable_apimonitoring "true")}}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "exec") (eq .ConfigItems.enable_apimonitoring "true")}}
- name: filters
mountPath: /etc/config/default-filters
{{ end }}
Expand All @@ -295,7 +295,7 @@ spec:
configMap:
name: sandbox-tokeninfo-bridge-conf
{{ end }}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "true") (eq .ConfigItems.enable_apimonitoring "true") }}
{{ if and (ne .ConfigItems.skipper_routesrv_enabled "exec") (eq .ConfigItems.enable_apimonitoring "true") }}
- name: filters
configMap:
name: skipper-default-filters
Expand Down
2 changes: 2 additions & 0 deletions cluster/manifests/skipper/routesrv-deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ if ne .ConfigItems.skipper_routesrv_enabled "false" }}
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down Expand Up @@ -108,3 +109,4 @@ spec:
name: skipper-default-filters
optional: true
{{ end }}
{{ end }}
2 changes: 1 addition & 1 deletion cluster/node-pools/master-default/userdata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ write_files:
requests:
cpu: 100m
memory: 200Mi
- image: registry.opensource.zalan.do/teapot/admission-controller:master-138
- image: registry.opensource.zalan.do/teapot/admission-controller:master-139
name: admission-controller
lifecycle:
preStop:
Expand Down