Allow changing settings on an owned LB #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
change-settings-owned-lb
branch
from
0448228 to
b593285
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default adding a WAF ACL ID or a security group etc. to an ingress/routegroup would require the creation of a new load balancer. This makes sense for the cases where the load balancer is shared by multiple ingresses/routegroups but for those load balancers only owned by a single resource (via
zalando.org/aws-load-balancer-shared=false) it doesn't really make sense to create a new load balancer when the setting is just adding/changing a security group, WAF ACL or the TLS settings which can be done in-place on a running LB.This PR handles the above case so we reduce the situations where a new load balancer needs to be created.