Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Ignore metadata.generation in last-seen state checks and diffs #65

Merged
merged 1 commit into from
May 17, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 17, 2019

Issue : #64

Ignore the incremental changes of metadata.generation, which automatically happen on any PATCH operation.

There are no unit-tests on this module yet, to be done in #13.

@nolar nolar added the bug Something isn't working label May 17, 2019
@nolar nolar added this to the 1.0 milestone May 17, 2019
@nolar nolar requested a review from samurang87 as a code owner May 17, 2019 10:52
@zincr
Copy link

zincr bot commented May 17, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented May 17, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar merged commit 7d1db80 into zalando-incubator:master May 17, 2019
@nolar nolar deleted the no-generation-in-diffs branch May 19, 2019 13:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants