Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Extract the watching logic into a separate module #62

Merged
merged 2 commits into from
May 14, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 13, 2019

Issue : #13

It is done as a preparation for the tests of watch-streaming & event multiplexing tests (#63) — just to make both change-sets easier to review.

This extraction is same-for-same, no changes in the logic. Only the code cohesion is adjusted: the watch-calls are now next to the streaming/iterating routines, away from queueing part.

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label May 13, 2019
@nolar nolar added this to the 1.0 milestone May 13, 2019
@nolar nolar requested a review from samurang87 as a code owner May 13, 2019 13:18
@nolar nolar changed the title Extract watching logic into a separate module Extract the watching logic into a separate module May 13, 2019
@zincr
Copy link

zincr bot commented May 13, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented May 13, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar removed the request for review from samurang87 May 13, 2019 19:06
@nolar nolar merged commit 7e026cb into zalando-incubator:master May 14, 2019
@nolar nolar deleted the extract-watching branch May 14, 2019 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants