Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Test end-to-end with the real cluster (minikube) #54

Merged
merged 9 commits into from
May 22, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented May 3, 2019

Issue : #52

With this, the framework is tested for the very basic things, which can be missed in the unit-test: that it starts and works at all, and communicates with the Kubernetes API normally: both for watching and for patching.

Previously, we had an internal incident when the operator failed to start since the RBAC permissions were missing, but the unit-tests were all green. Now, such things should be detected.

The e2e tests are executed at the end, since they are usually slow (tens of seconds), and want the regular unit-tests to provide the results fast.

More e2e tests will be added in separate PRs. Currently, it is only a supporting infrastructure for this kind of tests, and a demo with the "./examples/" (also to check that the examples are still valid).


Kubernetes 1.11.x is disabled since Minikube/kubeadm fails on the CRI preflight checks, and neither Kubernetes nor Minikube are our system-under-test — the framework and its examples are the the system-under-test.

Kubernetes 1.10.x is disabled due to conflicting behaviour of spec.version in CRD files: either 1.10 or 1.14 fails, but 1.14 is valuable as the future release, so 1.10 can be sacrificed (to not introduce the legacy on the project start).


This is how it looks in Travis (as an example): https://travis-ci.org/nolar/kopf/builds/527762283

image
image

@zincr
Copy link

zincr bot commented May 3, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Dependency Licensing
✅ Large Commits
✅ Approvals
✅ Specification

Details on how to resolve are provided below


Dependency Licensing

All dependencies specified in package manager files must be reviewed, banned dependency licenses will block the merge, all new dependencies introduced in this pull request will give a warning, but not block the merge

Please ensure that only dependencies with licenses compatible with the license of this project is included in the pull request.

  • ℹ️ Could not process requirements.txt for new dependencies
     

@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label May 3, 2019
@nolar nolar added this to the 1.0 milestone May 3, 2019
@nolar nolar mentioned this pull request May 19, 2019
19 tasks
@nolar nolar force-pushed the 52-minikube-testing branch from 0bc8277 to cf2bcca Compare May 22, 2019 09:40
@nolar nolar marked this pull request as ready for review May 22, 2019 09:41
@nolar nolar requested a review from samurang87 as a code owner May 22, 2019 09:41
@nolar nolar merged commit 20d943d into zalando-incubator:master May 22, 2019
@nolar nolar deleted the 52-minikube-testing branch May 22, 2019 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants