Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Test the lifecycles #35

Merged
merged 4 commits into from
May 3, 2019
Merged

Test the lifecycles #35

merged 4 commits into from
May 3, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Apr 21, 2019

Issue : #13

Test and fix the lifecycle callbacks. They are used to select the handlers to be executed on each handling cycle.

By default, asap is used, and it was slightly broken due to hard-coded structure of the status field (the change was done before importing to GitHub, but not reflected in this line). Now, it uses the provided function to get the retry count — from the same module where this value is set/updated.

@nolar nolar added the bug Something isn't working label Apr 21, 2019
@zincr
Copy link

zincr bot commented Apr 21, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

@zincr
Copy link

zincr bot commented Apr 21, 2019

🤖 zincr found 1 problem , 1 warning

❌ Approvals
ℹ️ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

@nolar nolar changed the title Tests lifecycles Test the lifecycles Apr 21, 2019
@nolar nolar mentioned this pull request Apr 22, 2019
19 tasks
@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Apr 26, 2019
@nolar nolar force-pushed the tests-lifecycles branch from 6c1a9f0 to 6404e21 Compare April 29, 2019 16:43
@nolar nolar marked this pull request as ready for review April 29, 2019 16:44
@nolar nolar requested a review from samurang87 as a code owner April 29, 2019 16:44
@nolar nolar added this to the 1.0 milestone Apr 30, 2019
@nolar nolar merged commit 4af5ec9 into master May 3, 2019
@nolar nolar deleted the tests-lifecycles branch May 3, 2019 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants