This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Make finalizer's name configurable, thus allowing multiple operator with different identities to handle the same resources with advanced handlers (anything different than
on.event
).Description
As a side-effect of #331, the operator gained possibility to change its own identity by using different prefixes or fields instead of the hard-coded Kopf's names/domains. This allowed multiple operators handling the same resources with advanced handlers (anything different than
on.event
; e.g.on.create
,on.update
,on.delete
, etc; also,kopf.daemon
&kopf.timer
).However, only one finalizer was used for all operators:
kopf.zalando.org/KopfFinalizerMarker
(hard-coded). This could lead to different operators possibly colliding with each other.With this PR, it is now possible to also configure the finalizer's name/domain. This is the final thing with operator's identity left that could not be configured.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt