Split handers & callbacks types for resource-related handlers #329
Conversation
🤖 zincr found 0 problems , 1 warningDetails on how to resolve are provided below Large CommitsChecks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of
|
🤖 zincr found 1 problem , 1 warningDetails on how to resolve are provided below ApprovalsAll proposed changes must be reviewed by project maintainers before they can be merged Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.
Large CommitsChecks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of
|
nolar
force-pushed
the
split-handers-types
branch
from
463b1bf to
419c3f6
Compare
|
This pull request introduces 1 alert when merging 419c3f6 into de23abe - view on LGTM.com new alerts:
|
Same as the respective registries and causes are already specialised. Needed for extra typing, and to introduce additional kind of handlers.
These classes and modules are deprecated anyway, so there is no neeed to keep them in a nice state, and make it the right way. Only minimally sufficient fix is enough to make it both work and pass the type-checks.
nolar
force-pushed
the
split-handers-types
branch
from
419c3f6 to
194c33c
Compare
|
This pull request introduces 1 alert when merging 194c33c into f70e556 - view on LGTM.com new alerts:
|
The handlers return coroutines, not the results directly. With some handlers (such as daemons soon), there could be specialised protocols with slightly different signatures (kwargs types).
|
@haikoschol Ouch. One more time plz (with a new commit)? |
Sorry about the delay. I saw it yesterday or so but then forgot about it again. |
What do these changes do?
Move the code around and rename some types & classes for callbacks & handlers.
No user-facing changes.
Description
This is the last preparing PR before the daemons & timers PR (#330).
Here, we just move the code around and rename classes. It would be messy to have these in the daemons & timers PR, so it goes separately.
Specifically, the resource-related handlers are split into resource-changing & resource-watching — same as it is already done for registries. These handlers & callbacks are de factor different anyway, but were declared as the same for laziness reasons. In the daemons & timers PR, also resource-spawning handlers & daemon/timer callbacks will be added with their own signatures.
No behavioural changes, no user-facing changes.
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt