This repository has been archived by the owner on Sep 14, 2020. It is now read-only.
Enable LGTM checks and fix few LGTM alerts #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Improve the codebase to resolve the remaining LGTM's warnings and some of the recommendations.
LGTM itself is enabled via GitHub actions/integrations, so no code changes are needed.
Description
LGMT is a code quality control tool (one of them) — as in "looks good to me": https://lgtm.com/
This project's analysis can be previewed at https://lgtm.com/projects/g/zalando-incubator/kopf/
The code logic is changed in few places — presumably, with no behavioural changes (just try-except-else restructuring to a flat code).
Issues/PRs
Type of changes
Checklist
CONTRIBUTORS.txt