Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Test registry and matching of handlers by causes #29

Merged
merged 4 commits into from
Apr 18, 2019
Merged

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Apr 14, 2019

These tests "freeze" the public interface of the library regarding the registries and matching of handlers by causes (i.e. resources-events-fields) — to prevent accidental regressions.

Issue : #13

@zincr
Copy link

zincr bot commented Apr 14, 2019

🤖 zincr found 0 problems , 1 warning

ℹ️ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Large Commits

Checks all commits for large additions to a single file. Large commits should be reviewed more carefully for potential copyright and licensing issues

This file contains a substantial change, please review to determine if the change comes from an external source and if there are any copyright or licensing issues to be aware of

@nolar nolar force-pushed the tests-registry branch 2 times, most recently from 0ed5f28 to 4357765 Compare April 15, 2019 00:07
@nolar nolar mentioned this pull request Apr 15, 2019
19 tasks
@nolar nolar marked this pull request as ready for review April 15, 2019 11:51
@nolar nolar requested a review from samurang87 as a code owner April 15, 2019 11:51
@nolar nolar changed the title Tests registry and matching of handlers by causes Test registry and matching of handlers by causes Apr 16, 2019
Cause()


def test_all_args(mocker):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the use of this test? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test that all declared (publicly promised) args are accepted, none of them suddenly change their name, none of them are removed.

But mostly for the properties, the same: none are removed or renamed.

Both the class constructor and its properties are considered as part of the public interfaces. And the tests, by concept, should "freeze" the public promises, and they should not change when the code is changed.

Though, maybe there are some other better approaches to do this (freeze the public interface).

@nolar nolar merged commit 7cf8495 into master Apr 18, 2019
@nolar nolar deleted the tests-registry branch April 18, 2019 12:07
@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Apr 26, 2019
@nolar nolar added this to the 1.0 milestone Apr 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants