Skip to content
This repository has been archived by the owner on Sep 14, 2020. It is now read-only.

Restrict kubernetes client library to version 9.x.x #135

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

nolar
Copy link
Contributor

@nolar nolar commented Jul 4, 2019

Issue : #134, kubernetes-client/python#866

Description

Restrict kubernetes client library to <10.0.0, as 10.0.0 is broken (both for Kopf and for an isolated example).

A hotfix version kopf==0.17.post1 was released to hot-fix this issue for regular use of Kopf via pip install kopf (0.17 is the latest released version to the moment).

But this same restriction must be in the master branch before the next version is released (i.e. for 0.18).

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@nolar nolar added the bug Something isn't working label Jul 4, 2019
@nolar nolar requested a review from samurang87 as a code owner July 4, 2019 14:09
@zincr
Copy link

zincr bot commented Jul 4, 2019

🤖 zincr found 0 problems , 0 warnings

✅ Large Commits
✅ Approvals
✅ Specification
✅ Dependency Licensing

@zincr
Copy link

zincr bot commented Jul 4, 2019

🤖 zincr found 1 problem , 0 warnings

❌ Approvals
✅ Large Commits
✅ Specification
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

  • ✅ Approved by PR author @nolar
  • ❌ 1 additional approval needed
     

@nolar nolar merged commit 51da125 into zalando-incubator:master Jul 4, 2019
@nolar nolar deleted the 134-kubernetes-10.0.0 branch July 4, 2019 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants