Replace deprecated golint with revive

[A-Kamaee]

Summary

The golint linter has been deprecated since v1.41.0 (June 15, 2021). Recently, on April 27, 2024, golangci-lint replaced the deprecation warning with an error for deprecated linters, including golint (reference). As a result, our CI pipeline began to fail due to the usage of golint.

Changes

• Removed golint: golint has been removed from our golangci-lint configuration due to its deprecation and the subsequent error enforcement in golangci-lint.
• Added revive: Integrated revive as a replacement linter to continue maintaining code quality standards.

Details

• Configuration:
  • Enabled revive in .golangci.yml.
  • Disabled golint to prevent pipeline failures.
  • Configured revive to ensure it aligns with our previous golint settings and added necessary rules for maintaining code quality.
• Cyclomatic Complexity:
  • Maintained gocyclo configuration with a minimum complexity threshold set to 20.

Benefits

• Compliance: Aligns our project with the latest golangci-lint standards and prevents CI pipeline failures.
• Code Quality: Continues to enforce code quality checks using a maintained and actively supported linter (revive).

Reference Links

• Deprecation and removal of golint in golangci-lint
• Revive Linter Documentation

Testing

• Verified the updated configuration by running golangci-lint locally and ensuring no new issues were introduced.
• Confirmed that the CI pipeline passes successfully with the updated linter configuration.

[otrosien]

👍

[A-Kamaee]

👍

[mikkeloscar]

👍

[A-Kamaee]

Thanks for prompt approval. 🙏