Skip to content
Back to pull request #602

fix: make Modal's onRequestClose mandatory and call it on close #1317

Sign in to view logs

fix: make Modal's onRequestClose mandatory and call it on close

fix: make Modal's onRequestClose mandatory and call it on close #1317

Triggered via pull request December 13, 2023 15:37
@targostargos
opened #602
fix-modal
Status Success
Total duration 1m 6s
Artifacts –

nodejs.yml

on: pull_request
nodejs  /  prepare
3s
nodejs / prepare
nodejs  /  lint-eslint
46s
nodejs / lint-eslint
nodejs  /  lint-prettier
25s
nodejs / lint-prettier
nodejs  /  lint-check-types
28s
nodejs / lint-check-types
Matrix: nodejs / test
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
nodejs / lint-eslint: src/app-data/loaders/biologicLoader.ts#L29
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/biologicLoader.ts#L46
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/cdfLoader.ts#L19
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/jcampLoader.ts#L24
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/jcampLoader.ts#L80
Unexpected any. Specify a different type
nodejs / lint-eslint: src/app-data/loaders/jcampLoader.ts#L81
Unexpected any. Specify a different type
nodejs / lint-eslint: src/app-data/loaders/loadMeasurements.ts#L26
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/loadMeasurements.ts#L44
Unexpected 'todo' comment: 'TODO: should we accept empty data?'
nodejs / lint-eslint: src/app-data/loaders/proprietary/agilent/cary500Loader.ts#L21
Unexpected 'todo' comment: 'TODO: load in parallel'
nodejs / lint-eslint: src/app-data/loaders/spcLoader.ts#L24
Unexpected 'todo' comment: 'TODO: load in parallel'