Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable roi filtering #104

Closed
wants to merge 13 commits into from
Closed

feat: enable roi filtering #104

wants to merge 13 commits into from

Conversation

moonayyur
Copy link
Contributor

#88

@lpatiny
Copy link
Contributor

lpatiny commented Apr 24, 2024

  • Composant de blueprintJS: slider ?
  • At first develop the component (possibly reusable) in pixelium that looks like:
    image
  • Based on filtering of one column the histogram is updated in the other columns
  • To create the values of the histogram you can use: https://github.com/mljs/spectra-processing/blob/main/src/x/xHistogram.ts
  • Keep search line: Small filter icon to add a filter, display values if filter active and a x to remove the filter.
  • Filters are only applied if column is visible and should be removed from the filtering state !
  • Remember which columns are sorted (if any) and save in the preferences state.

Slider

Props:

  • min
  • max
  • values - array of numbers of possible values (histogram is calculated internnaly)
  • onChange(min,max) => {}

Copy link

cloudflare-workers-and-pages bot commented Apr 25, 2024

Deploying pixelium with  Cloudflare Pages  Cloudflare Pages

Latest commit: adfa1db
Status: ✅  Deploy successful!
Preview URL: https://38b318d1.pixelium.pages.dev
Branch Preview URL: https://88-delete-a-roi.pixelium.pages.dev

View logs

@stropitek
Copy link
Contributor

@moonayyur can you try to reproduce and fix #105?

From what I've tried it is only the case on the preview of this branch, not on pixelium.zakodium.com

@moonayyur moonayyur closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants