Skip to content

Commit

Permalink
ARROW-17717: [R] Lintr error on CI (apache#14113)
Browse files Browse the repository at this point in the history
The new release of lintr has a new feature - giving a warning when code is commented out - which is causing the lintr-containing CI job to fail.  We could have pinned to a previous version of lintr, but that seem like a useful feature & the lines of code which trigger it seem like reasonable exceptions, so I've just added a #nolint flag on each of them.

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
  • Loading branch information
thisisnic authored and zagto committed Oct 7, 2022
1 parent f6c3eed commit a39847c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions r/tests/testthat/test-dplyr-funcs-type.R
Original file line number Diff line number Diff line change
Expand Up @@ -420,12 +420,12 @@ test_that("type checks with is() giving R types", {
i64_is_chr = is(i64, "character"),
i64_is_fct = is(i64, "factor"),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_int = is(i64, "integer"),
# i64_is_int = is(i64, "integer"), # nolint
i64_is_i64 = is(i64, "integer64"),
i64_is_lst = is(i64, "list"),
i64_is_lgl = is(i64, "logical"),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_num = is(i64, "numeric"),
# i64_is_num = is(i64, "numeric"), # nolint
lst_is_chr = is(lst, "character"),
lst_is_fct = is(lst, "factor"),
lst_is_int = is(lst, "integer"),
Expand Down Expand Up @@ -504,10 +504,10 @@ test_that("type checks with is.*()", {
transmute(
i64_is_chr = is.character(i64),
# TODO: investigate why this is not matching when testthat runs it
# i64_is_dbl = is.double(i64),
# i64_is_dbl = is.double(i64), # nolint
i64_is_fct = is.factor(i64),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_int = is.integer(i64),
# i64_is_int = is.integer(i64), # nolint
i64_is_i64 = is.integer64(i64),
i64_is_lst = is.list(i64),
i64_is_lgl = is.logical(i64),
Expand Down

0 comments on commit a39847c

Please sign in to comment.