MAIN: Update lists for better dynamic lists, pagination, async #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I put the sample pages into a single top-level command, so deploying that extension didn't add 5 top-level commands to your palette * I tightened up some of the phrasing for the samples, and the builtins, to be less repetitive * I added a few icons * I made the markdown sample longer (and work more reliably) * and also thank you Hawker for auto-format on save, you the man (targets #142)
zadjii-msft
added a commit
that referenced
this pull request
Nov 12, 2024
As discussed in #121. Adds a new `IListItem.TextToSuggest` property. If an extension populates that, and the user hits right-arrow when the item is selected, we'll set the `SearchText` to that text. I didn't give it a UI treatment, because 1. I'm not good at XAML 2. As noted in #121 (comment), there's complicated edge cases here. You have to track what's actually been typed, and then also have a ghost suggestion for the very first item (before the user types/up/downs at all). I didn't think it was valuable to implement that right now before we have A Real App. * targets #144 * which targets #142 * which targets #141 and those guys are all merged as of #150
Comment on lines
+104
to
+121
| private ScrollViewer? FindScrollViewer(DependencyObject parent) | ||
| { | ||
| if (parent is ScrollViewer) | ||
| { | ||
| return (ScrollViewer)parent; | ||
| } | ||
|
|
||
| for (var i = 0; i < VisualTreeHelper.GetChildrenCount(parent); i++) | ||
| { | ||
| var child = VisualTreeHelper.GetChild(parent, i); | ||
| var result = FindScrollViewer(child); | ||
| if (result != null) | ||
| { | ||
| return result; | ||
| } | ||
| } | ||
|
|
||
| return null; |
There was a problem hiding this comment.
FYI, we have helpers in the WCT for this, so if you're in C# never write these again 😋
ItemsList.FindAscendent<ScrollViewer>();There was a problem hiding this comment.
oh thank god 😅
This felt terribly dirty writing it, but it seemed like it was the only way to do it 🤷
There was a problem hiding this comment.
It's in the CommunityToolkit.WinUI.Extensions package 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally in #142 and #144, but github didn't automatically change the base branch 😨
As discussed in #77.
Biggest change is that
IDynamicListPagedoesn't haveGetItems(String query)anymore. Instead, the host will call theSearchTextsetter, and the list can raiseItemsChangedto let the host know to callGetItemsagainSee src/modules/cmdpal/Exts/EverythingExtension/Pages/EverythingExtensionPage.cs for an example of how to update dynamic extensions.
Closes #131
Closes #77