Fix bugs where car would not wake for command #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alandtse
commented
Mar 5, 2019
alandtse
commented
- Add wake_up and retry logic decorators for get and post functions. Fixes (Setting climate operation_mode often fails #16, Calls to Tesla API do not appear throttled #28)
- Add wake_if_asleep parameter to avoid waking vehicles. Commands should set to True; updates to False. Resolves (Check sleep state before polling #18)
* Disable updates for asleep vehicles * Change delay rate to exponential growth
* Add throttle for get_vehicles() call * Fix check on response for True boolean * Fix update to return boolean for wake_up wrapper * Add check for dict
* Add throttle for get_vehicles() call * Fix check on response for True boolean * Fix update to return boolean for wake_up wrapper * Add check for dict * Add debugging to connection.py * Fix bug where check did not properly unwrap response
* Fix potential infinite recursion on wake_up with wrapper
* Add further wrapper retries once car woken up to handle `could_not_wake_buses` error * Add connection timeout debugging * Fix pylint indentation errors
* Add catch for RetryLimitErrors in updates * Remove redundant debug info
* Remove redundant debug info * Fix controller to populate data with None on exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.