Fix ZFS templates #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed templates with inappropriate use of $1 and $2 variables for 5.4 and .60 someone else can wrangle with the XML for 5.0 I am not
Closed
|
Your commit log said "fixed templates with inappropriate use of $1 and $2 variables for 5.4 and 6.0" When are $1 and $2 inappropriate for Zabbix 6 templates? I still see plenty of them in the current ZFS templates, such as: UserParameter=zfs.zpool.health[*],/usr/bin/sudo /sbin/zpool list -H -o health $1 I read that after Zabbix 4 these vars are supposed to be replaced by Macro names? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZFS montoring template is fixed. This is tested and working.
Not Done:
updated 5.0 profile. I don't have the patience for this, and don't use 5.0. Someone else can contribute.