feature(grammar): allow key-value options #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @zaach |
|
For the syntax, I'd prefer something that resembles what the lexical grammar already uses, e.g. |
|
@zaach done. Now it consumes |
GerHobbelt
added a commit
to GerHobbelt/ebnf-parser
that referenced
this pull request
Oct 26, 2015
…icate work on zaach#6. Merged to flag this as inspected and processed, however sticking with my own implementation of this as it's stricter (e.g. only '=' token production inside `conditions` lex phase (a.k.a. condition state) and tested support for quoted and quote-carrying values. Hence 'use ours' on this merge. Sorry. # Conflicts: # bnf.l # bnf.y # ebnf-parser.js # tests/bnf_parse.js
GerHobbelt
added a commit
to GerHobbelt/ebnf-parser
that referenced
this pull request
Oct 26, 2015
…cate work on zaach#6. Merged to flag this as inspected and processed, however sticking with my own implementation of this as it's stricter (e.g. only '=' token production inside `conditions` lex phase (a.k.a. condition state) and tested support for quoted and quote-carrying values. Hence 'use ours' on this merge. Sorry. Note: one test tile change included. # Conflicts: # bnf.l # bnf.y # ebnf-parser.js # tests/bnf_parse.js # Conflicts: # bnf.y # tests/bnf_parse.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you have ability to specify options in grammar file.
It's enough for me, because I have to declare my module name in my file.
I can do it in JSON file and I want to do it in BNF files as well.
I've tested these changes allow to do it. I will can write like this
Jison will get this option and declare generated parser with proper module name