Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support mapState/mapMutations and parameters checking #1

Closed
wants to merge 1 commit into from
Closed

feat: support mapState/mapMutations and parameters checking #1

wants to merge 1 commit into from

Conversation

natsusola
Copy link
Contributor

@natsusola natsusola commented Jun 6, 2020

Thanks for creating this wonderful plugin.

Features

  • Support mapState
    Fix the definition of the type of mapState returned.
    Before
    image

  • Support mapMutations
    image
    image

  • Support checking the parameters of actions and mutations
    image
    image

@zWingz zWingz self-requested a review June 8, 2020 12:02
ActionObject,
} from 'vuex';

export type PromiseAction<T> = T extends ActionHandler<any, any>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it return never if use ActionObject
image
image

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it conflict to T extends ActionObject

@zWingz
Copy link
Owner

zWingz commented Jun 8, 2020

open in #3

@zWingz zWingz closed this Jun 8, 2020
@natsusola natsusola deleted the feat/apply-state-mutation branch June 8, 2020 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants