🔧 change logic to see if ds or table exists #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal of this MR is to tackle the issue mentioned here. The explanation is pretty much there.
Implementation
Right now to check if something exists the code tries to create the dataset with the parameter
exists_ok
, which in the internal bigquery library it just avoids raising an Exception as documented here.The issue is that those calls are still created on the API and then handled in code, and your logs are going to be flooded with errors in your bigquery API.
With this MR the aim is to add an extra call to get the resources (dataset or table) and handle the
NotFound
exception itself. There is a potential cons that is making an additional call to the API to check if the resource actually exists.Summoning @z3z1ma @blancaruano